Message 338216 - Python tracker

Message338216

Author	mjsaah
Recipients	belopolsky, eric.smith, matrixise, miss-islington, mjsaah, p-ganssle, pablogsal, terry.reedy, thatiparthy, vstinner, xdegaye, xtreak
Date	2019-03-18.12:45:42
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<CAAGJmtTBgz09yvdFqvA_Jz9exnucFvhOiqp25=ebLT2LZw9M_Q@mail.gmail.com>
In-reply-to	<1552910266.77.0.360373810079.issue35066@roundup.psfhosted.org>

Content
While I agree with Victor that reworking time.strftime to be more portable is a great idea, this issue was never about that; it was about making exception throwing behavior consistent across datetime's two strftime implementations (python and C), and also bringing them into line with what time.strftime does. Xavier's bug shows that my test methodology didn't take into account the range of libc strftime behavior. The patch proposed makes sense to me.

Content

While I agree with Victor that reworking time.strftime to be more portable
is a great idea, this issue was never about that; it was about making
exception throwing behavior consistent across datetime's two strftime
implementations (python and C), and also bringing them into line with what
time.strftime does.

Xavier's bug shows that my test methodology didn't take into account the
range of libc strftime behavior. The patch proposed makes sense to me.

History
Date	User	Action	Args
2019-03-18 12:45:42	mjsaah	set	recipients: + mjsaah, terry.reedy, belopolsky, vstinner, eric.smith, xdegaye, matrixise, thatiparthy, p-ganssle, pablogsal, miss-islington, xtreak
2019-03-18 12:45:42	mjsaah	link	issue35066 messages
2019-03-18 12:45:42	mjsaah	create