Message 338301 - Python tracker

Message338301

Author	pablogsal
Recipients	lkollar, ncoghlan, ned.deily, pablogsal, ronaldoussoren, vstinner
Date	2019-03-19.00:32:14
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1552955534.17.0.43400119251.issue36236@roundup.psfhosted.org>
In-reply-to

Content
Yup. But what is the best way to signal the caller that _PyPathConfig_ComputeArgv0 has failed because _Py_wgetcwd has failed without changing the API massively? Right now if _PyPathConfig_ComputeArgv0 returns null is assumed that is due to a memory error when calling PyUnicode_FromWideChar. So either we stop returning _Py_INIT_NO_MEMORY() and then skip appending to sys_path or we change the API to signal different problems to the caller. Also, notice that the same function is used in sysmodule.c in PySys_SetArgvEx: If argv[0] is not '-c' nor '-m', prepend argv[0] to sys.path.

Content

Yup. But what is the best way to signal the caller that _PyPathConfig_ComputeArgv0 has failed because _Py_wgetcwd has failed without changing the API massively? 

Right now if _PyPathConfig_ComputeArgv0 returns null is assumed that is due to a memory error when calling PyUnicode_FromWideChar. So either we stop returning _Py_INIT_NO_MEMORY() and then skip appending to sys_path or we change the API to signal different problems to the caller.

Also, notice that the same function is used in sysmodule.c in PySys_SetArgvEx:

If argv[0] is not '-c' nor '-m', prepend argv[0] to sys.path.

History
Date	User	Action	Args
2019-03-19 00:32:14	pablogsal	set	recipients: + pablogsal, ronaldoussoren, ncoghlan, vstinner, ned.deily, lkollar
2019-03-19 00:32:14	pablogsal	set	messageid: <1552955534.17.0.43400119251.issue36236@roundup.psfhosted.org>
2019-03-19 00:32:14	pablogsal	link	issue36236 messages
2019-03-19 00:32:14	pablogsal	create