Message 339021 - Python tracker

Message339021

Author	jdemeyer
Recipients	eric.snow, jdemeyer, matrixise, pitrou, scoder, serhiy.storchaka
Date	2019-03-28.08:42:13
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1553762533.33.0.648236342968.issue35983@roundup.psfhosted.org>
In-reply-to

Content
Changing types like that looks like an ugly hack and a recipe for breakage. For example, in list_dealloc(), the following needs the type to be correct: if (numfree < PyList_MAXFREELIST && PyList_CheckExact(op)) free_list[numfree++] = op; else Py_TYPE(op)->tp_free((PyObject *)op); Could you please clarify your opinion: do you think that there's something wrong with PR 11841? And if yes: what's wrong with it? Or are you just giving optional suggestions?

Content

Changing types like that looks like an ugly hack and a recipe for breakage. For example, in list_dealloc(), the following needs the type to be correct:

    if (numfree < PyList_MAXFREELIST && PyList_CheckExact(op))
        free_list[numfree++] = op;
    else
        Py_TYPE(op)->tp_free((PyObject *)op);

Could you please clarify your opinion: do you think that there's something wrong with PR 11841? And if yes: what's wrong with it? Or are you just giving optional suggestions?

History
Date	User	Action	Args
2019-03-28 08:42:13	jdemeyer	set	recipients: + jdemeyer, pitrou, scoder, eric.snow, serhiy.storchaka, matrixise
2019-03-28 08:42:13	jdemeyer	set	messageid: <1553762533.33.0.648236342968.issue35983@roundup.psfhosted.org>
2019-03-28 08:42:13	jdemeyer	link	issue35983 messages
2019-03-28 08:42:13	jdemeyer	create