Message 339023 - Python tracker

Message339023

Author	jdemeyer
Recipients	eric.snow, jdemeyer, matrixise, pitrou, scoder, serhiy.storchaka
Date	2019-03-28.09:10:13
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1553764213.2.0.463106422051.issue35983@roundup.psfhosted.org>
In-reply-to

Content
> It disables the trashcan mechanism Yes, it disables the trashcan in some cases. But only when using the trashcan mechanism would probably crash CPython anyway due to a double deallocation. So at the very least, PR 11841 improves things from "crashing whenever the trashcan is used" to "crashing on stack overflows". Do you have a real example where PR 11841 actually makes things worse? > and does not provide other mechanism for solving that problem. The recommended thing to do is that the subclass also implements the trashcan. See OrderedDict for an example: both the base class "dict" and the subclass "OrderedDict" use the trashcan.

Content

> It disables the trashcan mechanism

Yes, it disables the trashcan in some cases. But only when using the trashcan mechanism would probably crash CPython anyway due to a double deallocation. So at the very least, PR 11841 improves things from "crashing whenever the trashcan is used" to "crashing on stack overflows".

Do you have a real example where PR 11841 actually makes things *worse*?

> and does not provide other mechanism for solving that problem.

The recommended thing to do is that the subclass also implements the trashcan. See OrderedDict for an example: both the base class "dict" and the subclass "OrderedDict" use the trashcan.

History
Date	User	Action	Args
2019-03-28 09:10:13	jdemeyer	set	recipients: + jdemeyer, pitrou, scoder, eric.snow, serhiy.storchaka, matrixise
2019-03-28 09:10:13	jdemeyer	set	messageid: <1553764213.2.0.463106422051.issue35983@roundup.psfhosted.org>
2019-03-28 09:10:13	jdemeyer	link	issue35983 messages
2019-03-28 09:10:13	jdemeyer	create