Message 339424 - Python tracker

Message339424

Author	houglum
Recipients	houglum
Date	2019-04-04.02:45:33
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1554345933.73.0.102710422294.issue36522@roundup.psfhosted.org>
In-reply-to

Content
This is a follow-up to https://bugs.python.org/issue33365. The fix for that issue (see https://github.com/python/cpython/pull/6611) added a statement to also print header values, but it does not account for the case where multiple values exist for the same header name, e.g. if my response contained these headers: x-goog-hash: crc32c=KAwGng== x-goog-hash: md5=eB5eJF1ptWaXm4bijSPyxw== then the debug output would print whichever of those values is returned from `self.headers.get("x-goog-hash")` for both prints: header: x-goog-hash: crc32c=KAwGng== header: x-goog-hash: crc32c=KAwGng== The iteration should instead be done using self.headers.items(), which will return the key and value pair to be printed. I'll send a GitHub PR shortly.

Content

This is a follow-up to https://bugs.python.org/issue33365.  The fix for that issue (see https://github.com/python/cpython/pull/6611) added a statement to also print header values, but it does not account for the case where multiple values exist for the same header name, e.g. if my response contained these headers:

x-goog-hash: crc32c=KAwGng==
x-goog-hash: md5=eB5eJF1ptWaXm4bijSPyxw==

then the debug output would print whichever of those values is returned from `self.headers.get("x-goog-hash")` for both prints:

header: x-goog-hash: crc32c=KAwGng==
header: x-goog-hash: crc32c=KAwGng==

The iteration should instead be done using self.headers.items(), which will return the key and value pair to be printed. I'll send a GitHub PR shortly.

History
Date	User	Action	Args
2019-04-04 02:45:33	houglum	set	recipients: + houglum
2019-04-04 02:45:33	houglum	set	messageid: <1554345933.73.0.102710422294.issue36522@roundup.psfhosted.org>
2019-04-04 02:45:33	houglum	link	issue36522 messages
2019-04-04 02:45:33	houglum	create