Message 340528 - Python tracker

Message340528

Author	matrixise
Recipients	docs@python, eric.smith, matrixise, mfisherlevine, xtreak
Date	2019-04-19.08:34:54
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<20190419083450.mozqaiwn4qhk6rxb@xps>
In-reply-to	<1555651585.97.0.635825435487.issue36661@roundup.psfhosted.org>

Content
We could change the example with ``` from dataclasses import dataclass @dataclass class InventoryItem: ... ``` Because it's not specified in the documentation (header, that we need to import dataclass from dataclasses). +1 for a small update. You are free to propose a PR. Have a nice day, >I think the import is implied in the example since the docs page is for >dataclasses module but adding an explicit import to InventoryItem at >the top won't hurt too. Yep, but explicit is better than implicit.

Content

We could change the example with 

```
from dataclasses import dataclass

@dataclass
class InventoryItem:
    ...
```

Because it's not specified in the documentation (header, that we need to
import dataclass from dataclasses).

+1 for a small update.

You are free to propose a PR.

Have a nice day,

>I think the import is implied in the example since the docs page is for
>dataclasses module but adding an explicit import to InventoryItem at
>the top won't hurt too.
Yep, but explicit is better than implicit.

History
Date	User	Action	Args
2019-04-19 08:34:54	matrixise	set	recipients: + matrixise, eric.smith, docs@python, xtreak, mfisherlevine
2019-04-19 08:34:54	matrixise	link	issue36661 messages
2019-04-19 08:34:54	matrixise	create