Message 340760 - Python tracker

Message340760

Author	mark.dickinson
Recipients	SilentGhost, bup, fdrake, mark.dickinson
Date	2019-04-24.07:36:28
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1556091388.33.0.659080656801.issue36669@roundup.psfhosted.org>
In-reply-to

Content
> It's not obvious why it should. I'd say that it's not obvious why it shouldn't. The "weakproxy" type currently supports every single "PyNumberMethods" slot except matrix multiplication: see https://github.com/python/cpython/blob/bf94cc7b496a379e1f604aa2e4080bb70ca4020e/Objects/weakrefobject.c#L610-L645 It seems likely that this was an unintentional omission when matrix multiplication was added. I can't think of any good reason to support all but one (well, two, including the in-place method) of those PyNumberMethods. Supporting all of them gives a (conceptually) smaller, simpler object. I think this is a consistency bug that should be fixed.

Content

> It's not obvious why it should.

I'd say that it's not obvious why it shouldn't. The "weakproxy" type currently supports every single "PyNumberMethods" slot *except* matrix multiplication: see 

https://github.com/python/cpython/blob/bf94cc7b496a379e1f604aa2e4080bb70ca4020e/Objects/weakrefobject.c#L610-L645

It seems likely that this was an unintentional omission when matrix multiplication was added. I can't think of any good reason to support all but one (well, two, including the in-place method) of those PyNumberMethods. Supporting all of them gives a (conceptually) smaller, simpler object.

I think this is a consistency bug that should be fixed.

History
Date	User	Action	Args
2019-04-24 07:36:28	mark.dickinson	set	recipients: + mark.dickinson, fdrake, SilentGhost, bup
2019-04-24 07:36:28	mark.dickinson	set	messageid: <1556091388.33.0.659080656801.issue36669@roundup.psfhosted.org>
2019-04-24 07:36:28	mark.dickinson	link	issue36669 messages
2019-04-24 07:36:28	mark.dickinson	create