Message 341490 - Python tracker

Message341490

Author	terry.reedy
Recipients	gvanrossum, serhiy.storchaka, terry.reedy
Date	2019-05-06.07:42:44
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1557128564.17.0.380001807047.issue36807@roundup.psfhosted.org>
In-reply-to

Content
The io doc says for IOBase flush() Flush the write buffers of the stream if applicable. This does nothing for read-only and non-blocking streams. and for BufferedWriter flush() Force bytes held in the buffer into the raw stream. A BlockingIOError should be raised if the raw stream blocks. On 3.x, open(filename, "wb"), used in writefile(), returns a BufferedWriter. So it seems than an exception is possible, which would crash IDLE without try-except. Serhiy, please read the previous message(s). Do you remember if you intended to remove the f.flush in writefile(), which Guido proposes to restore?

Content

The io doc says for IOBase flush()
    Flush the write buffers of the stream if applicable. This does nothing for read-only and non-blocking streams.

and for BufferedWriter flush()
    Force bytes held in the buffer into the raw stream. A BlockingIOError should be raised if the raw stream blocks.

On 3.x, open(filename, "wb"), used in writefile(), returns a BufferedWriter.  So it seems than an exception is possible, which would crash IDLE without try-except.

Serhiy, please read the previous message(s).  Do you remember if you intended to remove the f.flush in writefile(), which Guido proposes to restore?

History
Date	User	Action	Args
2019-05-06 07:42:44	terry.reedy	set	recipients: + terry.reedy, gvanrossum, serhiy.storchaka
2019-05-06 07:42:44	terry.reedy	set	messageid: <1557128564.17.0.380001807047.issue36807@roundup.psfhosted.org>
2019-05-06 07:42:44	terry.reedy	link	issue36807 messages
2019-05-06 07:42:44	terry.reedy	create