Message342909
| Author | remi.lapeyre |
|---|---|
| Recipients | gregory.p.smith, mbussonn, pablogsal, remi.lapeyre, rhettinger, steven.daprano |
| Date | 2019-05-20.14:57:55 |
| SpamBayes Score | -1.0 |
| Marked as misclassified | Yes |
| Message-id | <1558364275.23.0.958989367737.issue36906@roundup.psfhosted.org> |
| In-reply-to |
| Content | |
|---|---|
Hi @steven.daprano, @gregory.p.smith. I added the first version of my PR for review.
One issue with it is that in:
def f():
return " foo".dedent()
f will have both " foo" and "foo" in its constants even if the first is not used anymore. Removing it requires looping over the code once more while marking the constants seen in a set and I was not sure if this was ok. |
|
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2019-05-20 14:57:55 | remi.lapeyre | set | recipients: + remi.lapeyre, rhettinger, gregory.p.smith, steven.daprano, mbussonn, pablogsal |
| 2019-05-20 14:57:55 | remi.lapeyre | set | messageid: <1558364275.23.0.958989367737.issue36906@roundup.psfhosted.org> |
| 2019-05-20 14:57:55 | remi.lapeyre | link | issue36906 messages |
| 2019-05-20 14:57:55 | remi.lapeyre | create | |