Message 343188 - Python tracker

Message343188

Author	blueyed
Recipients	blueyed
Date	2019-05-22.12:44:44
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1558529084.78.0.178705379805.issue37011@roundup.psfhosted.org>
In-reply-to

Content
bdb/pdb currently uses `sys.settrace(None)` when uninstalling its trace function (trace_dispatch), but should rather store the original trace function in the beginning and use this instead of `None`. While typically pdb is not used in tests, it is just good practice, given that there can only be a single trace function. I've done this via monkeypatching for pdbpp's tests, which resulted in an easy 2% coverage gain (https://github.com/antocuni/pdb/pull/253).

Content

bdb/pdb currently uses `sys.settrace(None)` when uninstalling its trace function (trace_dispatch), but should rather store the original trace function in the beginning and use this instead of `None`.

While typically pdb is not used in tests, it is just good practice, given that there can only be a single trace function.

I've done this via monkeypatching for pdbpp's tests, which resulted in an easy 2% coverage gain (https://github.com/antocuni/pdb/pull/253).

History
Date	User	Action	Args
2019-05-22 12:44:44	blueyed	set	recipients: + blueyed
2019-05-22 12:44:44	blueyed	set	messageid: <1558529084.78.0.178705379805.issue37011@roundup.psfhosted.org>
2019-05-22 12:44:44	blueyed	link	issue37011 messages
2019-05-22 12:44:44	blueyed	create