Message343395
| Author | remi.lapeyre |
|---|---|
| Recipients | blueyed, remi.lapeyre |
| Date | 2019-05-24.15:10:12 |
| SpamBayes Score | -1.0 |
| Marked as misclassified | Yes |
| Message-id | <1558710612.63.0.89224240138.issue37022@roundup.psfhosted.org> |
| In-reply-to |
| Content | |
|---|---|
This part of the code is already used in three places and your patch would add two occurrences of of it, I think it would be great to put the part that print the exception in a private method, to avoid duplicating it all over the place. Doing this seems small enough to me that I think it could be done in the same PR to avoid the overhead of having two separates PRs. |
|
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2019-05-24 15:10:12 | remi.lapeyre | set | recipients: + remi.lapeyre, blueyed |
| 2019-05-24 15:10:12 | remi.lapeyre | set | messageid: <1558710612.63.0.89224240138.issue37022@roundup.psfhosted.org> |
| 2019-05-24 15:10:12 | remi.lapeyre | link | issue37022 messages |
| 2019-05-24 15:10:12 | remi.lapeyre | create | |