Message 364305 - Python tracker

Message364305

Author BTaskaya
Recipients BTaskaya, benjamin.peterson, eamanu, levkivskyi, serhiy.storchaka, yselivanov
Date 2020-03-16.10:00:54
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1584352856.07.0.43116239678.issue36287@roundup.psfhosted.org>
In-reply-to
Content
@serhiy.storchaka, with these ASDL signatures, I have a patch that would omit default values for both Nones and [] in case they are redundant. But this is a bit different than your approach so I wanted to ask what's your opinion about adding an extra argument called omit_defaults, and only omit defaults it present. I'm adding this because unlike your first patch, these aren't actually defaults when creating the objects (like ast.Module(body=[x]) != ast.Module(body=[x], type_ignores=[])) so doing anything other than looking to that representation would be different than the actual result. What're your opinions about this? (I'm submitting the initial version of the patch before doing a PR)
History
Date User Action Args
2020-03-16 10:00:56BTaskayasetrecipients: + BTaskaya, benjamin.peterson, serhiy.storchaka, yselivanov, levkivskyi, eamanu
2020-03-16 10:00:56BTaskayasetmessageid: <1584352856.07.0.43116239678.issue36287@roundup.psfhosted.org>
2020-03-16 10:00:56BTaskayalinkissue36287 messages
2020-03-16 10:00:54BTaskayacreate