Message 364968 - Python tracker

Message364968

Author	phsilva
Recipients	amaury.forgeotdarc, corona10, eric.snow, isoschiz, kylotan, lukasz.langa, miss-islington, pconnell, phsilva, santoso.wijaya, shihai1991, tlesher, vstinner, ysj.ray
Date	2020-03-25.01:46:39
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1585100800.07.0.137732099062.issue1635741@roundup.psfhosted.org>
In-reply-to

Content
Updating on my findings on msg364833. It looks like encodings module is not being destoyed at all and keeping all the encoding refs alive. Looks like some cycle but I am not sure yet how to solve it. To validate this, I: - removed codec_search_cach of PyInterpreterState. - Py_DECREFd(encodings) after loading it on codecs.c. Before: 4376 refs left (37fcbb65d4) After : 352 refs left (-92%) I've updated the changes at https://github.com/python/cpython/compare/master...phsilva:remove-codec-caches (not a proposed patch, just to validate the idea)

Content

Updating on my findings on msg364833.

It looks like encodings module is not being destoyed at all and keeping all the encoding refs alive. Looks like some cycle but I am not sure yet how to solve it.

To validate this, I:
 - removed codec_search_cach of PyInterpreterState.
 - Py_DECREFd(encodings) after loading it on codecs.c.

Before: 4376 refs left (37fcbb65d4)
After :  352 refs left (-92%)

I've updated the changes at https://github.com/python/cpython/compare/master...phsilva:remove-codec-caches (not a proposed patch, just to validate the idea)

History
Date	User	Action	Args
2020-03-25 01:46:40	phsilva	set	recipients: + phsilva, amaury.forgeotdarc, kylotan, vstinner, tlesher, ysj.ray, santoso.wijaya, lukasz.langa, eric.snow, pconnell, isoschiz, corona10, miss-islington, shihai1991
2020-03-25 01:46:40	phsilva	set	messageid: <1585100800.07.0.137732099062.issue1635741@roundup.psfhosted.org>
2020-03-25 01:46:40	phsilva	link	issue1635741 messages
2020-03-25 01:46:39	phsilva	create