Message 366424 - Python tracker

Message366424

Author	hniksic
Recipients	aeros, asvetlov, bquinlan, hniksic, pitrou, torsten
Date	2020-04-14.18:30:12
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1586889012.61.0.174285933768.issue36780@roundup.psfhosted.org>
In-reply-to

Content
Thanks for the clarification, I didn't know about the change to non-daemon threads. I still think this patch is useful, and won't harm general use because it is opt-in, just like daemon threads themselves. I suggest to update the PR to specify non-waiting pool at the point of creation rather than in shutdown(). (That will also make it more acceptable for the same option not being supported for process pools - it is ok for constructor signatures to differ.) If there is interest, someone should take over the PR, as I have changed jobs and no longer have time to actively pursue this issue.

Content

Thanks for the clarification, I didn't know about the change to non-daemon threads.

I still think this patch is useful, and won't harm general use because it is opt-in, just like daemon threads themselves. I suggest to update the PR to specify non-waiting pool at the point of creation rather than in shutdown(). (That will also make it more acceptable for the same option not being supported for process pools - it is ok for constructor signatures to differ.)

If there is interest, someone should take over the PR, as I have changed jobs and no longer have time to actively pursue this issue.

History
Date	User	Action	Args
2020-04-14 18:30:12	hniksic	set	recipients: + hniksic, bquinlan, pitrou, asvetlov, torsten, aeros
2020-04-14 18:30:12	hniksic	set	messageid: <1586889012.61.0.174285933768.issue36780@roundup.psfhosted.org>
2020-04-14 18:30:12	hniksic	link	issue36780 messages
2020-04-14 18:30:12	hniksic	create