Message 367152 - Python tracker

Message367152

Author	geitda
Recipients	brett.cannon, geitda, jcdlr, om364@, terry.reedy
Date	2020-04-23.22:06:07
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1587679567.42.0.917803814158.issue33065@roundup.psfhosted.org>
In-reply-to

Content
Looks good when testing both the minimal example and the pgpdump original case. I added the import at the top, and changed the original line 173 from value = repr(value) to value = reprlib.repr(value) This is based on lines 160 & 161 in reprlib (we need a Repr instance, but reprlib makes it's own for us to use). I get a nice boring and not-crashy result in the debug window for Locals: data b'' self <BinaryData instance at 0x2726a0ab880> Thanks for the fix, Terry! I shouldn't expect any strange side-effects from this, should I?

Content

Looks good when testing both the minimal example and the pgpdump original case.

I added the import at the top, and changed the original line 173 from

value = repr(value)

to

value = reprlib.repr(value)

This is based on lines 160 & 161 in reprlib (we need a Repr instance, but reprlib makes it's own for us to use).

I get a nice boring and not-crashy result in the debug window for Locals:

data   b''
self   <BinaryData instance at 0x2726a0ab880>

Thanks for the fix, Terry!
I shouldn't expect any strange side-effects from this, should I?

History
Date	User	Action	Args
2020-04-23 22:06:07	geitda	set	recipients: + geitda, brett.cannon, terry.reedy, jcdlr, om364@
2020-04-23 22:06:07	geitda	set	messageid: <1587679567.42.0.917803814158.issue33065@roundup.psfhosted.org>
2020-04-23 22:06:07	geitda	link	issue33065 messages
2020-04-23 22:06:07	geitda	create