Message370205
| Author | vstinner |
|---|---|
| Recipients | abacabadabacaba, achimnol, aeros, asvetlov, fantix, lukasz.langa, miss-islington, ned.deily, vstinner, yselivanov |
| Date | 2020-05-28.13:48:52 |
| SpamBayes Score | -1.0 |
| Marked as misclassified | Yes |
| Message-id | <1590673732.21.0.897207907084.issue30064@roundup.psfhosted.org> |
| In-reply-to |
| Content | |
|---|---|
I created https://github.com/python/cpython/pull/20485 to skip the unstable tests until someone fix them. IMO it's better to skip the test than reverting the fix, since the fix does fix a race condition. The test is still failing on buildbots which makes analysis of buildbot failures more difficult. For example, a SQLite change got 3 different 4 different bugs on buildbots: https://github.com/python/cpython/pull/20448#issuecomment-635350054 See the "revert on fail" policy for buildbots: https://pythondev.readthedocs.io/ci.html#revert-on-fail > I'm also a bit skeptical about relying on `time.sleep(0.01)` at the end of the loop in `_basetest_sock_recv_racing()` Yeah, please avoid sleep as a synchronization primitive: https://pythondev.readthedocs.io/unstable_tests.html#don-t-use-sleep-as-synchronization |
|
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2020-05-28 13:48:52 | vstinner | set | recipients: + vstinner, fantix, ned.deily, asvetlov, abacabadabacaba, lukasz.langa, yselivanov, achimnol, miss-islington, aeros |
| 2020-05-28 13:48:52 | vstinner | set | messageid: <1590673732.21.0.897207907084.issue30064@roundup.psfhosted.org> |
| 2020-05-28 13:48:52 | vstinner | link | issue30064 messages |
| 2020-05-28 13:48:52 | vstinner | create | |