Message377175
| Author | mafredri |
|---|---|
| Recipients | Anthony Sottile, ZackerySpytz, batisteo, brett.cannon, lys.nikolaou, mafredri, vinay.sajip, xtreak |
| Date | 2020-09-19.15:55:21 |
| SpamBayes Score | -1.0 |
| Marked as misclassified | Yes |
| Message-id | <1600530921.21.0.653859390752.issue35328@roundup.psfhosted.org> |
| In-reply-to |
| Content | |
|---|---|
I believe GH-21587 does not fully address this issue because VIRTUAL_ENV_PROMPT is being conditionally set only if VIRTUAL_ENV_DISABLE_PROMPT is unset. Shell prompts must set VIRTUAL_ENV_DISABLE_PROMPT to non-empty to prevent venv from hijacking PS1. I'm one of the maintainers of the Pure prompt for zsh, and it would be great if VIRTUAL_ENV_PROMPT could always be set, just as VIRTUAL_ENV is too. |
|
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2020-09-19 15:55:21 | mafredri | set | recipients: + mafredri, brett.cannon, vinay.sajip, Anthony Sottile, lys.nikolaou, ZackerySpytz, xtreak, batisteo |
| 2020-09-19 15:55:21 | mafredri | set | messageid: <1600530921.21.0.653859390752.issue35328@roundup.psfhosted.org> |
| 2020-09-19 15:55:21 | mafredri | link | issue35328 messages |
| 2020-09-19 15:55:21 | mafredri | create | |