Message 382524 - Python tracker

Message382524

Author	gregory.p.smith
Recipients	gregory.p.smith, oconnor663, vstinner
Date	2020-12-04.20:16:41
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1607113002.26.0.664620930539.issue42558@roundup.psfhosted.org>
In-reply-to

Content
I agree with Victor. When code launches a process with subprocess APIs, it is expected that the subprocess module manages the process. Calling os.waitpid directly instead of using subprocess's APIs breaks that expectation. Also, WNOWAIT and waitid() (not waitpid()) are not available on all platforms. Nor is pidfd_open(). Code using any of those for such a PR needs to be conditional on their runtime availability.

Content

I agree with Victor.  When code launches a process with subprocess APIs, it is expected that the subprocess module manages the process.

Calling os.waitpid directly instead of using subprocess's APIs breaks that expectation.

Also, WNOWAIT and waitid() (not waitpid()) are not available on all platforms.  Nor is pidfd_open().  Code using any of those for such a PR needs to be conditional on their runtime availability.

History
Date	User	Action	Args
2020-12-04 20:16:42	gregory.p.smith	set	recipients: + gregory.p.smith, vstinner, oconnor663
2020-12-04 20:16:42	gregory.p.smith	set	messageid: <1607113002.26.0.664620930539.issue42558@roundup.psfhosted.org>
2020-12-04 20:16:42	gregory.p.smith	link	issue42558 messages
2020-12-04 20:16:41	gregory.p.smith	create