Message 394999 - Python tracker

Message394999

Author	cybergrind
Recipients	cybergrind, python-dev, vinay.sajip
Date	2021-06-03.13:17:31
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1622726251.67.0.996959796718.issue44291@roundup.psfhosted.org>
In-reply-to

Content
Oh, sorry bad wording. The current implementation has reconnection logic only for UNIX sockets The patch adds reconnection logic for UDP/TCP sockets as well. I've done it with minimal changes to the existing code to accomplish that. And probably it can be merged. But in general, it looks like we can refactor SysLogHandler to inherit from SocketHandler. Not sure if it should be done in this PR or better to create separate?

Content

Oh, sorry bad wording.

The current implementation has reconnection logic only for UNIX sockets
The patch adds reconnection logic for UDP/TCP sockets as well.


I've done it with minimal changes to the existing code to accomplish that. And probably it can be merged.

But in general, it looks like we can refactor SysLogHandler to inherit from SocketHandler. Not sure if it should be done in this PR or better to create separate?

History
Date	User	Action	Args
2021-06-03 13:17:31	cybergrind	set	recipients: + cybergrind, vinay.sajip, python-dev
2021-06-03 13:17:31	cybergrind	set	messageid: <1622726251.67.0.996959796718.issue44291@roundup.psfhosted.org>
2021-06-03 13:17:31	cybergrind	link	issue44291 messages
2021-06-03 13:17:31	cybergrind	create