Message 395177 - Python tracker

Message395177

Author	BTaskaya
Recipients	BTaskaya, belopolsky, benjamin.peterson, eric.snow, gregory.p.smith, kj, lukasz.langa, meador.inge, miss-islington, pablogsal, ppperry, terry.reedy
Date	2021-06-05.18:24:13
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1622917453.91.0.989534774857.issue11105@roundup.psfhosted.org>
In-reply-to

Content
> The stack size for a window build is currently set to 2MB, which is usually lesser than *nix 8MB. So I think an easy solution is to increase the stack size for windows builds. > I'm guessing release builds aren't affected because some of the Py_EnterRecursiveCall helper functions are probably inlined and thus use less of the stack. > Opinions are greatly appreciated. I don't think that we should make a global change for this case, AFAIK some of the core parts of the interpreter maintain their own recursion checks with different handling of windows limits. E.g; https://github.com/python/cpython/blob/fa106a685c1f199aca5be5c2d0277a14cc9057bd/Python/marshal.c#L25-L40 We might need to end up with the same motion and do the handling by ourselves. Wdyt @pablogsal @kj?

Content

> The stack size for a window build is currently set to 2MB, which is usually lesser than *nix 8MB. So I think an easy solution is to increase the stack size for windows builds.

> I'm guessing release builds aren't affected because some of the Py_EnterRecursiveCall helper functions are probably inlined and thus use less of the stack.

> Opinions are greatly appreciated.

I don't think that we should make a global change for this case, AFAIK some of the core parts of the interpreter maintain their own recursion checks with different handling of windows limits. E.g;

https://github.com/python/cpython/blob/fa106a685c1f199aca5be5c2d0277a14cc9057bd/Python/marshal.c#L25-L40

We might need to end up with the same motion and do the handling by ourselves. Wdyt @pablogsal @kj?

History
Date	User	Action	Args
2021-06-05 18:24:13	BTaskaya	set	recipients: + BTaskaya, terry.reedy, gregory.p.smith, belopolsky, benjamin.peterson, meador.inge, lukasz.langa, eric.snow, ppperry, pablogsal, miss-islington, kj
2021-06-05 18:24:13	BTaskaya	set	messageid: <1622917453.91.0.989534774857.issue11105@roundup.psfhosted.org>
2021-06-05 18:24:13	BTaskaya	link	issue11105 messages
2021-06-05 18:24:13	BTaskaya	create