Message 397523 - Python tracker

Message397523

Author	corona10
Recipients	corona10, lukasz.langa, rhettinger, serhiy.storchaka, vstinner
Date	2021-07-15.04:01:41
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1626321701.3.0.0810785235431.issue38210@roundup.psfhosted.org>
In-reply-to

Content
>Interestingly, this doesn't seem to have a negative effect on correctness as the silently omitted unhashable I think so too. The error actually raises when adding the object into the set. https://github.com/python/cpython/blob/818628c2da99ba0376313971816d472c65c9a9fc/Objects/dictobject.c#L4384 Since the target object to be added is dynamically generated, I think that the issue does not need to be fixed. Otherwise, we have to check that all objects are addable to `set` object before executing this operation but it looks harmful to performance.

Content

>Interestingly, this doesn't seem to have a negative effect on correctness as the silently omitted unhashable

I think so too.

The error actually raises when adding the object into the set.
https://github.com/python/cpython/blob/818628c2da99ba0376313971816d472c65c9a9fc/Objects/dictobject.c#L4384

Since the target object to be added is dynamically generated, I think that the issue does not need to be fixed.
Otherwise, we have to check that all objects are addable to `set` object before executing this operation but it looks harmful to performance.

History
Date	User	Action	Args
2021-07-15 04:01:41	corona10	set	recipients: + corona10, rhettinger, vstinner, lukasz.langa, serhiy.storchaka
2021-07-15 04:01:41	corona10	set	messageid: <1626321701.3.0.0810785235431.issue38210@roundup.psfhosted.org>
2021-07-15 04:01:41	corona10	link	issue38210 messages
2021-07-15 04:01:41	corona10	create