Message 398986 - Python tracker

Message398986

Author	BvB93
Recipients	BvB93, JelleZijlstra, farcat, gvanrossum, kj, lars2, lukasz.langa, miss-islington, serhiy.storchaka, uriyyo
Date	2021-08-05.10:30:29
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1628159429.59.0.124419497829.issue44524@roundup.psfhosted.org>
In-reply-to

Content
I do agree that it's nice to have a `__name__` for special forms, as they do very much behave like types even though they're strictly speaking not distinct classes. Whether we should have this feature is a distinct "problem" from its `__name__` being `None` (as can happen in its the current implementation), the latter of which is actively breaking tests over in https://github.com/numpy/numpy/pull/19612. I don't recall ever seeing a non-string name before, so I'd argue that this is a bug. It seems to be easy to fix though (see below for a `Union` example), so if there are objections I'd like to submit a PR. ``` - return _UnionGenericAlias(self, parameters) + return _UnionGenericAlias(self, parameters, name="Union") ```

Content

I do agree that it's nice to have a `__name__` for special forms, as they do very much behave like types even though they're strictly speaking not distinct classes.

Whether we should have this feature is a distinct "problem" from its `__name__` being `None` (as can happen in its the current implementation), 
the latter of which is actively breaking tests over in https://github.com/numpy/numpy/pull/19612.
I don't recall ever seeing a non-string name before, so I'd argue that this is a bug.

It seems to be easy to fix though (see below for a `Union` example), so if there are objections I'd like to submit a PR.

```
-    return _UnionGenericAlias(self, parameters)
+    return _UnionGenericAlias(self, parameters, name="Union")
```

History
Date	User	Action	Args
2021-08-05 10:30:29	BvB93	set	recipients: + BvB93, gvanrossum, farcat, lukasz.langa, serhiy.storchaka, JelleZijlstra, miss-islington, uriyyo, kj, lars2
2021-08-05 10:30:29	BvB93	set	messageid: <1628159429.59.0.124419497829.issue44524@roundup.psfhosted.org>
2021-08-05 10:30:29	BvB93	link	issue44524 messages
2021-08-05 10:30:29	BvB93	create