Message 400571 - Python tracker

Message400571

Author	methane
Recipients	Guido.van.Rossum, gvanrossum, iritkatriel, methane, rhettinger, serhiy.storchaka, terry.reedy
Date	2021-08-30.03:29:18
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1630294158.98.0.625042165521.issue36521@roundup.psfhosted.org>
In-reply-to

Content
> I think that would require a change in the signature of PyFunction_New. I don't think so. For example, func_annotation don't require changing PyFunction_New(). ``` case TARGET(MAKE_FUNCTION): { PyObject codeobj = POP(); PyFunctionObject func = (PyFunctionObject *) PyFunction_New(codeobj, GLOBALS()); (snip) if (oparg & 0x04) { assert(PyTuple_CheckExact(TOP())); func->func_annotations = POP(); } ```

Content

> I think that would require a change in the signature of PyFunction_New.

I don't think so. For example, func_annotation don't require changing PyFunction_New().

```
        case TARGET(MAKE_FUNCTION): {
            PyObject *codeobj = POP();
            PyFunctionObject *func = (PyFunctionObject *)
                PyFunction_New(codeobj, GLOBALS());
(snip)
            if (oparg & 0x04) {
                assert(PyTuple_CheckExact(TOP()));
                func->func_annotations = POP();
            }
```

History
Date	User	Action	Args
2021-08-30 03:29:19	methane	set	recipients: + methane, gvanrossum, rhettinger, terry.reedy, serhiy.storchaka, Guido.van.Rossum, iritkatriel
2021-08-30 03:29:18	methane	set	messageid: <1630294158.98.0.625042165521.issue36521@roundup.psfhosted.org>
2021-08-30 03:29:18	methane	link	issue36521 messages
2021-08-30 03:29:18	methane	create