Message57553
| Author | gvanrossum |
|---|---|
| Recipients | christian.heimes, gvanrossum, janssen |
| Date | 2007-11-15.19:40:29 |
| SpamBayes Score | 0.017357172 |
| Marked as misclassified | No |
| Message-id | <1195155629.91.0.570144649567.issue1451@psf.upfronthosting.co.za> |
| In-reply-to |
| Content | |
|---|---|
Looks good (after skimming). Some stylistic nits:
- Please fold lines >= 80 chars.
- Please strip trailing whitespace (for Python code, you won't be
allowed to submit with it present).
- You can fold long imports without using the dreaded backslash now, e.g.
from _ssl import (SSL_ERROR_ZERO_RETURN,
SSL_ERROR_WANT_READ, ...)
Then just check it in. (We'll be able to do the dup()'ing differently
soon, but I'd just as soon see your patch go in first.) |
|
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2007-11-15 19:40:30 | gvanrossum | set | spambayes_score: 0.0173572 -> 0.017357172 recipients: + gvanrossum, janssen, christian.heimes |
| 2007-11-15 19:40:29 | gvanrossum | set | spambayes_score: 0.0173572 -> 0.0173572 messageid: <1195155629.91.0.570144649567.issue1451@psf.upfronthosting.co.za> |
| 2007-11-15 19:40:29 | gvanrossum | link | issue1451 messages |
| 2007-11-15 19:40:29 | gvanrossum | create | |