Message62036
| Author | nnorwitz |
|---|---|
| Recipients | christian.heimes, nnorwitz |
| Date | 2008-02-04.06:31:31 |
| SpamBayes Score | 0.0024538613 |
| Marked as misclassified | No |
| Message-id | <1202106697.18.0.532340244715.issue1953@psf.upfronthosting.co.za> |
| In-reply-to |
| Content | |
|---|---|
I think sys is appropriate for clearing the cache. Lib/test/regrtest.py still has a reference to gc rather than sys. Why do the CompactFreeList APIs return an int that is always 0? Seems like they should return a real value or be void. I'm not sure why you changed the functions to keep a block_list_length. I doubt this API would be requested very often. Seems like it would be better to just calculate when necessary (or perhaps not even add the APIs). The only issue I have with the patch is the casting in the printf calls. These can lose information. On Win64, long is 32-bits, but size_t is 64-bits. See PY_FORMAT_SIZE_T in Include/pyport.h for how to handle this. |
|
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2008-02-04 06:31:37 | nnorwitz | set | spambayes_score: 0.00245386 -> 0.0024538613 recipients: + nnorwitz, christian.heimes |
| 2008-02-04 06:31:37 | nnorwitz | set | spambayes_score: 0.00245386 -> 0.00245386 messageid: <1202106697.18.0.532340244715.issue1953@psf.upfronthosting.co.za> |
| 2008-02-04 06:31:36 | nnorwitz | link | issue1953 messages |
| 2008-02-04 06:31:34 | nnorwitz | create | |