Message 63040 - Python tracker

Message63040

Author	belopolsky
Recipients	_doublep, belopolsky, benjamin.peterson, gvanrossum, nnorwitz, rhettinger
Date	2008-02-26.13:10:02
SpamBayes Score	0.0025176753
Marked as misclassified	No
Message-id	<1204031406.17.0.619967484837.issue1394@psf.upfronthosting.co.za>
In-reply-to

Content
I have added more tests as Neal suggested. See unreachable-code-with- tests.diff for a combined patch. I've rerun all tests after removing .pyc files and also with -O option (ensuring no existing .pyo files as well). All works. I've removed #if 0 block and changed "Verify" to "Ensure" in the RETURN_VALUE comment. Paul, maybe you and add an explanation why the added RETURN_VALUE will always be eliminated. I am not sure when python produces code with no terminating RETURN_VALUE in the first place.

Content

I have added more tests as Neal suggested. See unreachable-code-with-
tests.diff for a combined patch.  I've rerun all tests after removing 
.pyc files and also with -O option (ensuring no existing .pyo files as 
well). All works.

I've removed #if 0  block and changed "Verify" to "Ensure" in the 
RETURN_VALUE comment.  Paul, maybe you and add an explanation why the 
added RETURN_VALUE will always be eliminated.  I am not sure when python  
produces code with no terminating RETURN_VALUE in the first place.

History
Date	User	Action	Args
2008-02-26 13:10:07	belopolsky	set	spambayes_score: 0.00251768 -> 0.0025176753 recipients: + belopolsky, gvanrossum, nnorwitz, rhettinger, _doublep, benjamin.peterson
2008-02-26 13:10:06	belopolsky	set	spambayes_score: 0.00251768 -> 0.00251768 messageid: <1204031406.17.0.619967484837.issue1394@psf.upfronthosting.co.za>
2008-02-26 13:10:04	belopolsky	link	issue1394 messages
2008-02-26 13:10:04	belopolsky	create