Message 67745 - Python tracker

Message67745

Author	benjamin.peterson
Recipients	benjamin.peterson, ncoghlan
Date	2008-06-06.02:03:34
SpamBayes Score	0.019681798
Marked as misclassified	No
Message-id	<1afaf6160806051903i7955dde9ofec75609bbb8c689@mail.gmail.com>
In-reply-to	<1212717372.35.0.0651735564435.issue3042@psf.upfronthosting.co.za>

Content
On Thu, Jun 5, 2008 at 8:56 PM, Nick Coghlan <report@bugs.python.org> wrote: > > Nick Coghlan <ncoghlan@gmail.com> added the comment: > > The code changes in the patch look pretty good to me (although you > probably want to actually use @wraps inside _old_api!) That won't work because we are creating the method than we would pass to wraps. Changing old's __name__ to old_name should do the trick. > > There are obviously also documentation and test suite changes that will > be needed. Of course. I can do that.

Content

On Thu, Jun 5, 2008 at 8:56 PM, Nick Coghlan <report@bugs.python.org> wrote:
>
> Nick Coghlan <ncoghlan@gmail.com> added the comment:
>
> The code changes in the patch look pretty good to me (although you
> probably want to actually use @wraps inside _old_api!)

That won't work because we are creating the method than we would pass
to wraps. Changing old's __name__ to old_name should do the trick.
>
> There are obviously also documentation and test suite changes that will
> be needed.

Of course. I can do that.

History
Date	User	Action	Args
2008-06-06 02:03:36	benjamin.peterson	set	spambayes_score: 0.0196818 -> 0.019681798 recipients: + benjamin.peterson, ncoghlan
2008-06-06 02:03:35	benjamin.peterson	link	issue3042 messages
2008-06-06 02:03:35	benjamin.peterson	create