Message67886
| Author | alexandre.vassalotti |
|---|---|
| Recipients | alexandre.vassalotti, brett.cannon, hdiogenes |
| Date | 2008-06-10.02:14:02 |
| SpamBayes Score | 0.01668452 |
| Marked as misclassified | No |
| Message-id | <1213064051.45.0.53499411619.issue2918@psf.upfronthosting.co.za> |
| In-reply-to |
| Content | |
|---|---|
Here's a preliminary patch that add the C optimization for StringIO. All tests are passing except two which depends on the StringIO.buffer attribute of the TextIOWrapper class. Honestly, I am not sure what is the correct way to fix this. I cannot simply "fake" the attribute by returning a BytesIO object, since the file position of buffer is undecidable. It seems to me that the only way to fix these failing tests would be to define a FakeIO class, in their test file, that would wrap ByteIO with TextIOWrapper, just like the old and inefficient StringIO. So, any idea on what would be the best thing to do? |
|
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2008-06-10 02:14:11 | alexandre.vassalotti | set | spambayes_score: 0.0166845 -> 0.01668452 recipients: + alexandre.vassalotti, brett.cannon, hdiogenes |
| 2008-06-10 02:14:11 | alexandre.vassalotti | set | spambayes_score: 0.0166845 -> 0.0166845 messageid: <1213064051.45.0.53499411619.issue2918@psf.upfronthosting.co.za> |
| 2008-06-10 02:14:09 | alexandre.vassalotti | link | issue2918 messages |
| 2008-06-10 02:14:08 | alexandre.vassalotti | create | |