Message 70529 - Python tracker

Message70529

Author	loewis
Recipients	amaury.forgeotdarc, barry, benjamin.peterson, donmez, giampaolo.rodola, gpolo, loewis, pitrou, teoliphant
Date	2008-07-31.20:14:53
SpamBayes Score	0.0015286074
Marked as misclassified	No
Message-id	<48921D3B.8070301@v.loewis.de>
In-reply-to	<1217516672.31.0.492306652616.issue3139@psf.upfronthosting.co.za>

Content
> But t# uses bf_getcharbuffer(), which does not seem to lock anything. Indeed. I think we can safely drop support for passing buffer objects into t# which have getbuffer/releasebuffer, so the check for releasebuffer being NULL should be added to t#. I think the bytearray object should refuse to implement getcharbuffer, anyway. > I wonder if this can lead to the same kind of problems, for example when > calling file_write with a binary file. It should be a text file to cause problems, right?

Content

> But t# uses bf_getcharbuffer(), which does not seem to lock anything.

Indeed. I think we can safely drop support for passing buffer objects
into t# which have getbuffer/releasebuffer, so the check for
releasebuffer being NULL should be added to t#.

I think the bytearray object should refuse to implement getcharbuffer,
anyway.

> I wonder if this can lead to the same kind of problems, for example when
> calling file_write with a binary file.

It should be a text file to cause problems, right?

History
Date	User	Action	Args
2008-07-31 20:14:55	loewis	set	recipients: + loewis, barry, teoliphant, amaury.forgeotdarc, pitrou, giampaolo.rodola, donmez, benjamin.peterson, gpolo
2008-07-31 20:14:54	loewis	link	issue3139 messages
2008-07-31 20:14:53	loewis	create