Message 74460 - Python tracker

Message74460

Author	amaury.forgeotdarc
Recipients	amaury.forgeotdarc, vstinner
Date	2008-10-07.15:45:27
SpamBayes Score	0.0019008098
Marked as misclassified	No
Message-id	<1223394330.82.0.103594259377.issue3975@psf.upfronthosting.co.za>
In-reply-to

Content
I still have remarks about traceback_unicode-3.patch, that I did not see before: - (a minor thing) PyMem_FREE(found_encoding) could appear only once, just after PyFile_FromFd. - I feel it dangerous to call the PyUnicode_AS_UNICODE() macro without checking that PyFile_GetLine() actually returned a PyUnicode object. - If the "truncated" variable is NULL, an exception has been set; it is necessary to exit the function.

Content

I still have remarks about traceback_unicode-3.patch, that I did not see
before:
- (a minor thing) PyMem_FREE(found_encoding) could appear only once,
just after PyFile_FromFd.
- I feel it dangerous to call the PyUnicode_AS_UNICODE() macro without
checking that PyFile_GetLine() actually returned a PyUnicode object.
- If the "truncated" variable is NULL, an exception has been set; it is
necessary to exit the function.

History
Date	User	Action	Args
2008-10-07 15:45:31	amaury.forgeotdarc	set	recipients: + amaury.forgeotdarc, vstinner
2008-10-07 15:45:30	amaury.forgeotdarc	set	messageid: <1223394330.82.0.103594259377.issue3975@psf.upfronthosting.co.za>
2008-10-07 15:45:29	amaury.forgeotdarc	link	issue3975 messages
2008-10-07 15:45:28	amaury.forgeotdarc	create