Message 76713 - Python tracker

Message76713

Author	vstinner
Recipients	giampaolo.rodola, lcatucci, vstinner
Date	2008-12-01.23:00:07
SpamBayes Score	1.1559496e-05
Marked as misclassified	No
Message-id	<1228172408.83.0.852470038012.issue4473@psf.upfronthosting.co.za>
In-reply-to

Content
You might split your patch into smaller patches, example: * patch 1: implement CAPA method * patch 2: POP3_SSL refatoring * patch 3: stls() method Comments: - Do you really need to keep a reference to the "raw" socket (self._sock) for a SSL connection? - I don't understand what is sock.shutdown(SHUT_RDWR). When is it needed? Does it change the behaviour? - Could you write a method to parse the capabilities because I hate long lambda function. You may write doctest for the new method :-)

Content

You might split your patch into smaller patches, example:
  * patch 1: implement CAPA method
  * patch 2: POP3_SSL refatoring
  * patch 3: stls() method

Comments:
- Do you really need to keep a reference to the "raw" socket 
(self._sock) for a SSL connection?
- I don't understand what is sock.shutdown(SHUT_RDWR). When is it 
needed? Does it change the behaviour?
- Could you write a method to parse the capabilities because I hate 
long lambda function. You may write doctest for the new method :-)

History
Date	User	Action	Args
2008-12-01 23:00:09	vstinner	set	recipients: + vstinner, giampaolo.rodola, lcatucci
2008-12-01 23:00:08	vstinner	set	messageid: <1228172408.83.0.852470038012.issue4473@psf.upfronthosting.co.za>
2008-12-01 23:00:08	vstinner	link	issue4473 messages
2008-12-01 23:00:07	vstinner	create