Message 77636 - Python tracker

Message77636

Author	vstinner
Recipients	fredrikj, loewis, mark.dickinson, rhettinger, terry.reedy, vstinner
Date	2008-12-11.23:05:36
SpamBayes Score	8.444454e-09
Marked as misclassified	No
Message-id	<1229036741.24.0.929295640586.issue3439@psf.upfronthosting.co.za>
In-reply-to

Content
Oops, you're right Mark: PyErr_Clear() is needed! New patch: - don't catch error different than PyExc_OverflowError in long_numbits() - clear error in long_numbits() - fix doc indentation About the indentation: i'm using >>svndiff='svn diff --diff-cmd="/usr/bin/diff" -x "-ub"'<< instead of svn diff because my editor removes trailing spaces. I prefer to keep the "fast path" (use _PyLong_NumBits) as you proposed in another message: Message75767.

Content

Oops, you're right Mark: PyErr_Clear() is needed! New patch:
 - don't catch error different than PyExc_OverflowError in 
long_numbits()
 - clear error in long_numbits()
 - fix doc indentation

About the indentation: i'm using >>svndiff='svn 
diff --diff-cmd="/usr/bin/diff" -x "-ub"'<< instead of svn diff 
because my editor removes trailing spaces.

I prefer to keep the "fast path" (use _PyLong_NumBits) as *you* 
proposed in another message: Message75767.

History
Date	User	Action	Args
2008-12-11 23:05:42	vstinner	set	recipients: + vstinner, loewis, rhettinger, terry.reedy, mark.dickinson, fredrikj
2008-12-11 23:05:41	vstinner	set	messageid: <1229036741.24.0.929295640586.issue3439@psf.upfronthosting.co.za>
2008-12-11 23:05:40	vstinner	link	issue3439 messages
2008-12-11 23:05:39	vstinner	create