Message78393
| Author | vstinner |
|---|---|
| Recipients | fabioz, pitrou, vstinner |
| Date | 2008-12-28.01:23:49 |
| SpamBayes Score | 1.7027533e-08 |
| Marked as misclassified | No |
| Message-id | <1230427431.01.0.919334227667.issue4705@psf.upfronthosting.co.za> |
| In-reply-to |
| Content | |
|---|---|
pitrou's patch changes PyFile_FromFd() behaviour for a text file
opened with buffering=0:
/* As a convenience, when buffering == 0 on a text file, we
open the underlying binary stream in unbuffered mode and
wrap it with a text stream in line-buffered mode. */
Why changing PyFile_FromFd() and not io.open() directly?
Note: I prefer Py_UnbufferedStdoutFlag=1 instead of
Py_UnbufferedStdoutFlag++ (for -u command line option).
Except the minor comments, I like the patch (and it has unit
tests!) ;-) |
|
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2008-12-28 01:23:51 | vstinner | set | recipients: + vstinner, pitrou, fabioz |
| 2008-12-28 01:23:51 | vstinner | set | messageid: <1230427431.01.0.919334227667.issue4705@psf.upfronthosting.co.za> |
| 2008-12-28 01:23:50 | vstinner | link | issue4705 messages |
| 2008-12-28 01:23:49 | vstinner | create | |