Message 80505 - Python tracker

Message80505

Author	mark.dickinson
Recipients	amaury.forgeotdarc, benjamin.peterson, brett.cannon, christian.heimes, georg.brandl, lemburg, mark.dickinson, pitrou, rhettinger
Date	2009-01-25.13:00:08
SpamBayes Score	7.380153e-05
Marked as misclassified	No
Message-id	<1232888411.3.0.0591591526512.issue1717@psf.upfronthosting.co.za>
In-reply-to

Content
Thanks, Antoine. Here's a new patch. > - two files have unwanted modifications on non-ASCII characters > (Lib/heapq.py and Lib/sqlite3/test/hooks.py) Fixed, I think. Could you double check? > - you haven't renamed "__cmp__" to "_cmp" in Lib/xmlrpc/client.py: > deliberate? Not deliberate! This __cmp__ should simply be removed, I think---the rich comparison methods are already present. > - in Lib/heapq.py, there's a "_cmp__" which should be "_cmp" Replaced "_cmp__" (which was in a comment) with "comparison".

Content

Thanks, Antoine.  Here's a new patch.

> - two files have unwanted modifications on non-ASCII characters
> (Lib/heapq.py and Lib/sqlite3/test/hooks.py)

Fixed, I think.  Could you double check?

> - you haven't renamed "__cmp__" to "_cmp" in Lib/xmlrpc/client.py:
> deliberate?

Not deliberate!  This __cmp__ should simply be removed, I think---the rich 
comparison methods are already present.

> - in Lib/heapq.py, there's a "_cmp__" which should be "_cmp"

Replaced "_cmp__" (which was in a comment) with "comparison".

History
Date	User	Action	Args
2009-01-25 13:00:11	mark.dickinson	set	recipients: + mark.dickinson, lemburg, brett.cannon, georg.brandl, rhettinger, amaury.forgeotdarc, pitrou, christian.heimes, benjamin.peterson
2009-01-25 13:00:11	mark.dickinson	set	messageid: <1232888411.3.0.0591591526512.issue1717@psf.upfronthosting.co.za>
2009-01-25 13:00:10	mark.dickinson	link	issue1717 messages
2009-01-25 13:00:08	mark.dickinson	create