Message 80804 - Python tracker

Message80804

Author	benjamin.peterson
Recipients	amaury.forgeotdarc, benjamin.peterson, brett.cannon, sjmachin, vstinner
Date	2009-01-30.02:00:51
SpamBayes Score	2.4274225e-09
Marked as misclassified	No
Message-id	<1afaf6160901291800y2b6330dcp12282ebc5e2969eb@mail.gmail.com>
In-reply-to	<1233270818.59.0.883381370647.issue4626@psf.upfronthosting.co.za>

Content
On Thu, Jan 29, 2009 at 5:13 PM, STINNER Victor <report@bugs.python.org> wrote: > Ok, I created a new function PyTokenizer_FromUnicode(). I > choosed "FromUnicode" because the string is encoded in unicode (as > UTF-8, even if it's not the wchar_t* type). How about PyTokenizer_FromUTF8() then? > >> The (char ) cast in PyTokenizer_FromString is unneeded. > > The cast on the decode_str() result? It was already present in the > original code. I removed it in my new patch. No, I was referring to this line: tok->encoding = (char )PyMem_MALLOC

Content

On Thu, Jan 29, 2009 at 5:13 PM, STINNER Victor <report@bugs.python.org> wrote:
> Ok, I created a new function PyTokenizer_FromUnicode(). I
> choosed "FromUnicode" because the string is encoded in unicode (as
> UTF-8, even if it's not the wchar_t* type).

How about PyTokenizer_FromUTF8() then?

>
>> The (char *) cast in PyTokenizer_FromString is unneeded.
>
> The cast on the decode_str() result? It was already present in the
> original code. I removed it in my new patch.

No, I was referring to this line:

tok->encoding = (char *)PyMem_MALLOC

History
Date	User	Action	Args
2009-01-30 02:00:54	benjamin.peterson	set	recipients: + benjamin.peterson, brett.cannon, sjmachin, amaury.forgeotdarc, vstinner
2009-01-30 02:00:52	benjamin.peterson	link	issue4626 messages
2009-01-30 02:00:51	benjamin.peterson	create