Message 91646 - Python tracker

Message91646

Author	gregory.p.smith
Recipients	Eloff, amaury.forgeotdarc, gregory.p.smith, pitrou
Date	2009-08-16.22:01:01
SpamBayes Score	3.882438e-09
Marked as misclassified	No
Message-id	<1250460063.73.0.0883746301153.issue6281@psf.upfronthosting.co.za>
In-reply-to

Content
That code was indeed a mess. I've incorporated most suggestions from your cleaned up version (and fixed a bug in it) in trunk r74479. Have you ever seen __get_builtin_constructor fail in practice? I can imagine that packing up a stripped down python interpreter with only a subset of the hash extension modules would be the only time this would likely be encountered. I've changed your code to log an error and continue rather than silently continue when an expected hash function is not available. That error log may be overkill, perhaps we should just leave catching this problem up to the unittests.

Content

That code was indeed a mess.  I've incorporated most suggestions from
your cleaned up version (and fixed a bug in it) in trunk r74479.

Have you ever seen __get_builtin_constructor fail in practice?  I can
imagine that packing up a stripped down python interpreter with only a
subset of the hash extension modules would be the only time this would
likely be encountered.

I've changed your code to log an error and continue rather than silently
continue when an expected hash function is not available.  That error
log may be overkill, perhaps we should just leave catching this problem
up to the unittests.

History
Date	User	Action	Args
2009-08-16 22:01:03	gregory.p.smith	set	recipients: + gregory.p.smith, amaury.forgeotdarc, pitrou, Eloff
2009-08-16 22:01:03	gregory.p.smith	set	messageid: <1250460063.73.0.0883746301153.issue6281@psf.upfronthosting.co.za>
2009-08-16 22:01:02	gregory.p.smith	link	issue6281 messages
2009-08-16 22:01:01	gregory.p.smith	create