Message 97856 - Python tracker

Message97856

Author	pitrou
Recipients	alex, dmalcolm, pitrou, rhettinger
Date	2010-01-15.22:41:43
SpamBayes Score	0.0014246965
Marked as misclassified	No
Message-id	<1263595305.01.0.536419842471.issue6690@psf.upfronthosting.co.za>
In-reply-to

Content
No, you can't rely on the repr of a frozenset with multiple items. You should find another way of testing (if you are brave you could match the "frozenset(...)" with a regex and eval() it). Some comments on the patch: - there's a line or two in peephole.c which seems to use spaces for indentation; please always use tabs (for this file anyway) - instead of `self.assertTrue(X in Y)`, you can use `self.assertIn(X, Y)` (and `self.assertNotIn(X, Y)` for the negation)

Content

No, you can't rely on the repr of a frozenset with multiple items. You should find another way of testing (if you are brave you could match the "frozenset(...)" with a regex and eval() it).

Some comments on the patch:
- there's a line or two in peephole.c which seems to use spaces for indentation; please always use tabs (for this file anyway)
- instead of `self.assertTrue(X in Y)`, you can use `self.assertIn(X, Y)` (and `self.assertNotIn(X, Y)` for the negation)

History
Date	User	Action	Args
2010-01-15 22:41:45	pitrou	set	recipients: + pitrou, rhettinger, alex, dmalcolm
2010-01-15 22:41:45	pitrou	set	messageid: <1263595305.01.0.536419842471.issue6690@psf.upfronthosting.co.za>
2010-01-15 22:41:43	pitrou	link	issue6690 messages
2010-01-15 22:41:43	pitrou	create