Message 97858 - Python tracker

Message97858

Author	dmalcolm
Recipients	alex, dmalcolm, pitrou, rhettinger
Date	2010-01-16.00:13:35
SpamBayes Score	5.7549714e-05
Marked as misclassified	No
Message-id	<1263600819.51.0.110789021745.issue6690@psf.upfronthosting.co.za>
In-reply-to

Content
Thanks for the suggestions. Attached is a revised version of the patch. - I believe I've fixed all tab/space issues in this version of the patch, though I may have missed some (http://www.python.org/dev/tools/ doesn't recommend an automated way of checking this). - I've rewritten the selftests as you suggested, using re and eval - I've rewritten the new selftests to use assertIn, assertNotIn The existing tests don't use assertIn/assertNotIn; I'm working on a patch for that, but I'll file that as a separate bug.

Content

Thanks for the suggestions.

Attached is a revised version of the patch. 
  - I believe I've fixed all tab/space issues in this version of the patch, though I may have missed some (http://www.python.org/dev/tools/ doesn't recommend an automated way of checking this).
  - I've rewritten the selftests as you suggested, using re and eval
  - I've rewritten the new selftests to use assertIn, assertNotIn

The existing tests don't use assertIn/assertNotIn; I'm working on a patch for that, but I'll file that as a separate bug.

History
Date	User	Action	Args
2010-01-16 00:13:40	dmalcolm	set	recipients: + dmalcolm, rhettinger, pitrou, alex
2010-01-16 00:13:39	dmalcolm	set	messageid: <1263600819.51.0.110789021745.issue6690@psf.upfronthosting.co.za>
2010-01-16 00:13:37	dmalcolm	link	issue6690 messages
2010-01-16 00:13:36	dmalcolm	create