Message 99904 - Python tracker

Message99904

Author	mark.dickinson
Recipients	dmalcolm, eric.smith, georg.brandl, mark.dickinson
Date	2010-02-23.09:18:40
SpamBayes Score	2.1259617e-05
Marked as misclassified	No
Message-id	<1266916723.39.0.370692152206.issue7997@psf.upfronthosting.co.za>
In-reply-to

Content
> BTW, should the changes to the generated "configure" be excluded > from such patches, or should they be included? (to what extent do > they contain meaningful information during review?) Not sure. I think it's fine to leave the configure changes out of a posted patch, especially if you also add a tracker comment reminding potential reviewers to regenerate configure. If the generated configure changes are small, I don't see a problem with leaving them in the patch either.

Content

> BTW, should the changes to the generated "configure" be excluded
> from such patches, or should they be included? (to what extent do
> they contain meaningful information during review?)

Not sure.  I think it's fine to leave the configure changes out of a posted patch, especially if you also add a tracker comment reminding potential reviewers to regenerate configure.   If the generated configure changes are small, I don't see a problem with leaving them in the patch either.

History
Date	User	Action	Args
2010-02-23 09:18:43	mark.dickinson	set	recipients: + mark.dickinson, georg.brandl, eric.smith, dmalcolm
2010-02-23 09:18:43	mark.dickinson	set	messageid: <1266916723.39.0.370692152206.issue7997@psf.upfronthosting.co.za>
2010-02-23 09:18:41	mark.dickinson	link	issue7997 messages
2010-02-23 09:18:40	mark.dickinson	create