Install proxy cert on GitHub-hosted Ubuntu runners by mbg · Pull Request #3435 · github/codeql-action
This is mostly an experiment to install the private registry proxy cert system-wide on GitHub-hosted Ubuntu runners. This would provide some level of redundancy against cases where access to a private registry via the proxy fails at a later step because the certificate is not trusted.
Ideally this would be behind a FF, but we don't currently have access to those in start-proxy.
Risk assessment
For internal use only. Please select the risk level of this change:
- High risk: Changes are not fully under feature flags, have limited visibility and/or cannot be tested outside of production.
Which use cases does this change impact?
Workflow types:
- Managed - Impacts users with
dynamicworkflows (Default Setup, CCR, ...).
Products:
- Code Scanning - The changes impact analyses when
analysis-kinds: code-scanning. - Code Quality - The changes impact analyses when
analysis-kinds: code-quality.
Environments:
- Dotcom - Impacts CodeQL workflows on
github.comand/or GitHub Enterprise Cloud with Data Residency. - GHES - Impacts CodeQL workflows on GitHub Enterprise Server.
How did/will you validate this change?
- Test repository - This change will be tested on a test repository before merging.
- End-to-end tests - I am depending on PR checks (i.e. tests in
pr-checks).
If something goes wrong after this change is released, what are the mitigation and rollback strategies?
- Feature flags - All new or changed code paths can be fully disabled with corresponding feature flags.
- Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix.
How will you know if something goes wrong after this change is released?
- Telemetry - I rely on existing telemetry or have made changes to the telemetry.
- Dashboards - I will watch relevant dashboards for issues after the release. Consider whether this requires this change to be released at a particular time rather than as part of a regular release.
- Alerts - New or existing monitors will trip if something goes wrong with this change.
Are there any special considerations for merging or releasing this change?
- No special considerations - This change can be merged at any time.