fix: avoid pulling build-only compose images by ssongliu · Pull Request #12095 · 1Panel-dev/1Panel

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve docker-compose compatibility when reading images

GetDockerComposeCommand still falls back to the legacy docker-compose binary when the v2 plugin is unavailable (agent/utils/common/common.go:414-420), but this call now unconditionally uses config --format json --no-normalize. On hosts with legacy/older Compose CLIs, these flags are not supported, so getComposeImagesByCommand will always fail and force the weaker YAML fallback path, which is known to lose behavior (for example, it cannot read comma-separated compose paths because it does os.ReadFile(filePath) directly). This can break image pre-pull during compose up for existing supported deployments.

Useful? React with 👍 / 👎.