Replace `Track*`/`Track *` with `Monitor` in CISA-based decision model (2nd try) by ahouseholder · Pull Request #742 · CERTCC/SSVC
This PR replaces #738, which we merged too soon and reverted in #741
This PR modifies the "Track *" value in the CISA OutcomeGroup to be "Monitor". Based on feedback received that having two closely-named values "Track" and "Track *" can be a source of confusion for users of that outcome group.
Two incidental changes are also included:
- Fixed the
keyvalues forAttendandActin the python version of the CISA OutcomeGroup to match the keys found indocs/ssvc-calc/CISA-Coordinator.json - Updated the OutcomeGroup base object type hint to reflect actual usage (values are a
tupleinstead of alist)
CoPilot Summary
This pull request includes several updates to the docs/ssvc-calc and src/ssvc/outcomes directories to standardize terminology and improve code structure. The most important changes include renaming "Track*" to "Monitor" in JSON and HTML files, updating the OutcomeGroup class to use tuples instead of lists, and restructuring outcome groups in the codebase.
Terminology Standardization:
docs/ssvc-calc/CISA-Coordinator.json: Renamed "Track*" to "Monitor" in multiple entries to standardize terminology. [1] [2] [3] [4] [5]docs/ssvc-ccalc/findex.htmlanddocs/ssvc-calc/old_index.html: Updated "Track*" to "Monitor" in the vulnerability scoring decisions section. [1] [2]
Code Structure Improvements:
src/ssvc/outcomes/base.py: Changed theoutcomesattribute in theOutcomeGroupclass from a list to a tuple for better immutability and performance.src/ssvc/outcomes/groups.py: Updated theOutcomeGroupinstances to use the new "Monitor" terminology and restructured the CISA outcome group. Additionally, added new descriptions and keys for the "Act" outcome. [1] [2] [3] [4] [5] [6]