Add shapes argument to geo_im_from_array() in climada.util.plot by yklpaul0902 · Pull Request #805 · CLIMADA-project/climada_python
Comment on lines +275 to +277
| shapes : bool, optional | ||
| Overlay Earth's countries coastlines to matplotlib.pyplot axis. | ||
| The default is True |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would call this coastlines instead of shapes. Much clearer.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since other functioms like geo_bin_from_array(), geo_scatter_from_array(), etc, they all name them as shapes for turning on/off the plotting of coastline, I would suggest either having it as shapes in geo_im_from_array(), or renaming all relevant shapes as coastlines, to make it more consistent.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, let it be shapes then. It is a very bad name, but consistency of code is probably more important.