adapt to changed worldbank data by emanuel-schmid · Pull Request #841 · CLIMADA-project/climada_python
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the test! Could you maybe change the variable names in the test as indicated? Also, please add a Changelog entry. Then, we are ready to merge.
| @@ -199,10 +201,12 @@ def test_pca_CUB_2015_pass(self): | |||
| ref_year = 2015 | |||
| cntry_iso = 'CUB' | |||
| res_year, res_val, q = world_bank_wealth_account(cntry_iso, ref_year, no_land=1) | |||
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable names res_ and ref_ are really hard to distinguish. Could you maybe change the res_ to wb_?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters