Remove attribute-style accesses to (Geo)DataFrames columns and xarray Datasets variables and attributes within tutorials by spjuhel · Pull Request #941 · CLIMADA-project/climada_python
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked at your changes, it looks good now. There is still one typo to be fixed though.
Otherwise, I think I spotted a couple missed instances of attribute-style accesses:
In climada_hazard_TropCyclone.ipynb:
1753: "print('Daily max sustained wind:', tc_syn.max_sustained_wind.groupby('time.day').max())"
and in climada_util_calibrate.ipynb:
1042: "emdat_subset = emdat[(emdat.cal_region2 == \"NA1\") & (emdat.year >= 2010)]\n",
This aside, it looks all good, well done!