added get_bounds functions for EPSG 4326 by ValentinGebhart · Pull Request #980 · CLIMADA-project/climada_python

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I agree, this would be better. I changed it to raise a ValueError now.

My only doubt is that the function util.coordinates.get_country_geometries() existed before and if you input a list of ISO codes with one invalid code, it did NOT raise an error before (this is why I "only" added a warning). Wouldn't this be a potential problem for existing code to break down due to the error, or is it better to make aware that the input was not correct?