[SVLS-8179] add debug log for flush strategy by jchrostek-dd · Pull Request #974 · DataDog/datadog-lambda-extension
Comment on lines +91 to +96
|
|
||
| // Log all non-Extension telemetry events to avoid infinite loop | ||
| if !matches!(event.record, TelemetryRecord::Extension(_)) { | ||
| debug!("LOGS | Incoming telemetry event: {:?}", event.record); | ||
| } | ||
|
|
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are already logging telemetry events here:
| debug!("Telemetry event received: {:?}", event); |
Is the new log added to help debug what happens in between?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, helpful for what happens in between. When I was looking at logs for Durable Functions, it seemed like we were missing some things.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably revert this. If we’re missing something for durable functions then let’s find out why it’s not being captured and sent to Datadog or via a Datadog flare. This will cause us to double log everything the user sends if debug logs are enabled, which will more than 2x the cost for no value.