Home Original page

Switch system-tests to python 3.12 by cbeauchesne · Pull Request #139 · DataDog/dd-trace-cpp

Conversation

@cbeauchesne

Description

Per title

Motivation

Python 3.9 won/t be supported by end of July in system-tests

Additional Notes

Jira ticket: [PROJ-IDENT]

@pr-commenter

Benchmarks

Benchmark execution time: 2024-07-08 11:36:59

Comparing candidate commit f7d8fc9 in PR branch cbeauchesne/system-tests-3-12 with baseline commit 32f0338 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

@codecov-commenter

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.47%. Comparing base (32f0338) to head (f7d8fc9).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #139   +/-   ##
=======================================
  Coverage   94.47%   94.47%           
=======================================
  Files          73       73           
  Lines        3800     3800           
=======================================
  Hits         3590     3590           
  Misses        210      210

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cbeauchesne

@dmehala I can't find the system-tests run in circle CI, is it executed on PR ?

dmehala

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmehala

@cbeauchesne It's run only on main. To test you can remove the filter, then merge.