fix: Remote config service/env validation by zacharycmontoya · Pull Request #177 · DataDog/dd-trace-cpp

Description

Removes the remote config check that asserts a matching env / service, as this is incorrectly causing remote config payloads to be ignored

Motivation

This was motivated by a customer issue with adaptive sampling not working. When the tracer doesn't report an environment version but the Datadog agent does, incoming remote config payloads (which have already been verified by the Datadog agent) get rejected even though they are correct. This removes the validation and relies upon the Datadog agent verification.

Testing

The previous unit test has been removed as it's invalid, and the associated system-tests authored here have been tested locally with success: DataDog/system-tests#3778

Additional Notes

Jira ticket: APMAPI-1006