feat: support DD_TRACE_ENABLED dynamic configuration by dmehala · Pull Request #96 · DataDog/dd-trace-cpp
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This technique looks good. I like how it's consistent with previous use of ConfigManager.
There is the question, that you asked internally, of whether already-started traces should be allowed to be sent. A design where the answer is "no" might be better from a user perspective, but the implementation would be less elegant.
Please fix the test failure showing in CI, and also please add tests for the new behavior.